Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-26 Thread David Gibson
On Fri, 24 Jun 2016 09:21:18 +0200 Peter Krempa wrote: > On Fri, Jun 24, 2016 at 16:56:21 +1000, David Gibson wrote: > > On Fri, 24 Jun 2016 07:41:11 +0200 > > Peter Krempa wrote: > > > > > On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: > > > > > > [...] > > > > > > > > You a

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-24 Thread Peter Krempa
On Fri, Jun 24, 2016 at 16:56:21 +1000, David Gibson wrote: > On Fri, 24 Jun 2016 07:41:11 +0200 > Peter Krempa wrote: > > > On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: > > > > [...] > > > > > > You are correct - query-commands says whether 'query-hotpluggable-cpus' > > > > exis

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-24 Thread David Gibson
On Fri, 24 Jun 2016 07:41:11 +0200 Peter Krempa wrote: > On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: > > [...] > > > > You are correct - query-commands says whether 'query-hotpluggable-cpus' > > > exists as a command. But that is insufficient. See my review, or the > > > v2 pa

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Peter Krempa
On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: [...] > > You are correct - query-commands says whether 'query-hotpluggable-cpus' > > exists as a command. But that is insufficient. See my review, or the > > v2 patch, where the above poor wording was corrected to say what was > > rea

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Igor Mammedov
On Fri, 24 Jun 2016 14:56:51 +1000 David Gibson wrote: > On Thu, 23 Jun 2016 21:49:25 -0600 > Eric Blake wrote: > > > On 06/23/2016 08:56 PM, David Gibson wrote: > > > On Thu, 23 Jun 2016 22:23:23 +0200 > > > Peter Krempa wrote: > > > > > >> For management apps it's very useful to know whet

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread David Gibson
On Thu, 23 Jun 2016 21:49:25 -0600 Eric Blake wrote: > On 06/23/2016 08:56 PM, David Gibson wrote: > > On Thu, 23 Jun 2016 22:23:23 +0200 > > Peter Krempa wrote: > > > >> For management apps it's very useful to know whether the selected > >> machine type supports cpu hotplug via the new -devi

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Eric Blake
On 06/23/2016 08:56 PM, David Gibson wrote: > On Thu, 23 Jun 2016 22:23:23 +0200 > Peter Krempa wrote: > >> For management apps it's very useful to know whether the selected >> machine type supports cpu hotplug via the new -device approach. Using >> the presence of 'query-hotpluggable-cpus' is en

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread David Gibson
On Thu, 23 Jun 2016 22:23:23 +0200 Peter Krempa wrote: > For management apps it's very useful to know whether the selected > machine type supports cpu hotplug via the new -device approach. Using > the presence of 'query-hotpluggable-cpus' is enough for a withess. > > Add a property to 'MachineIn

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Eric Blake
On 06/23/2016 02:23 PM, Peter Krempa wrote: > For management apps it's very useful to know whether the selected > machine type supports cpu hotplug via the new -device approach. Using > the presence of 'query-hotpluggable-cpus' is enough for a withess. s/is enough/alone is not enough/ ? s/withess

[Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Peter Krempa
For management apps it's very useful to know whether the selected machine type supports cpu hotplug via the new -device approach. Using the presence of 'query-hotpluggable-cpus' is enough for a withess. Add a property to 'MachineInfo' called 'hotpluggable-cpus' that will report the presence of thi