Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-29 Thread David Gibson
On Wed, May 25, 2011 at 09:29:26AM +0200, Paolo Bonzini wrote: > On 05/25/2011 12:12 AM, David Gibson wrote: > >>@@ -602,6 +604,8 @@ static int spapr_vio_busdev_init(DeviceState *qdev, > >>DeviceInfo *qinfo) > >> } > >> > >> dev->qdev.id = id; > >>+dev->vio_irq_num = bus->irq++; > >>

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-25 Thread Paolo Bonzini
On 05/25/2011 12:12 AM, David Gibson wrote: @@ -602,6 +604,8 @@ static int spapr_vio_busdev_init(DeviceState *qdev, DeviceInfo *qinfo) } dev->qdev.id = id; +dev->vio_irq_num = bus->irq++; +dev->qirq = xics_find_qirq(spapr->icp, dev->vio_irq_num); I'd prefer to see an spapr

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread David Gibson
On Tue, May 24, 2011 at 01:45:05PM +0200, Paolo Bonzini wrote: > Right now the spapr devices cannot be instantiated with -device, > because the IRQs need to be passed to the spapr_*_create functions. > Do this instead in the bus's init wrapper. > > This is particularly important with the conversio

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/24/2011 03:03 PM, Markus Armbruster wrote: >> > This is particularly important with the conversion from scsi-disk >> > to scsi-{cd,hd} that Markus made. After his patches, if you >> > specify a scsi-cd device attached to an if=none drive, the default >> > VSCSI

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Paolo Bonzini
On 05/24/2011 03:03 PM, Markus Armbruster wrote: > This is particularly important with the conversion from scsi-disk > to scsi-{cd,hd} that Markus made. After his patches, if you > specify a scsi-cd device attached to an if=none drive, the default > VSCSI controller will not be created and,

Re: [Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Markus Armbruster
Paolo Bonzini writes: > Right now the spapr devices cannot be instantiated with -device, > because the IRQs need to be passed to the spapr_*_create functions. > Do this instead in the bus's init wrapper. > > This is particularly important with the conversion from scsi-disk > to scsi-{cd,hd} that

[Qemu-devel] [PATCH 1/3] spapr: allow creating devices with -device

2011-05-24 Thread Paolo Bonzini
Right now the spapr devices cannot be instantiated with -device, because the IRQs need to be passed to the spapr_*_create functions. Do this instead in the bus's init wrapper. This is particularly important with the conversion from scsi-disk to scsi-{cd,hd} that Markus made. After his patches, if