Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

2014-06-18 Thread Paolo Bonzini
Il 18/06/2014 13:11, Stefan Hajnoczi ha scritto: > > Actually this won't work. Link properties have to have a LinkProperty > opaque. > > The series I posted to add a "resolve" callback for properties can be used > here, fixing object_property_add_alias to add a "resolve" callback to the > newly-

Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

2014-06-18 Thread Stefan Hajnoczi
On Wed, Jun 11, 2014 at 2:35 AM, Paolo Bonzini wrote: > Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto: > >> @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj) >> object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), >> NULL); >> object_unref(OBJEC

Re: [Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto: @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj) object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL); object_unref(OBJECT(&dev->vdev)); qdev_alias_all_properties(DEVICE(&dev->vdev), ob

[Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

2014-06-10 Thread Stefan Hajnoczi
Up until now -device virtio-blk-pci,x-iothread= was used to assign an IOThread. This was a temporary solution while we cleaned up QOM link properties. This patch switches over to a QOM link property since it is now possible to restrict the setter to unrealized instances and automatically unref th