Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-03-11 Thread Cornelia Huck
On Mon, 11 Mar 2013 13:22:45 +0100 Alexander Graf wrote: > On 03/11/2013 01:16 PM, Paolo Bonzini wrote: > > Il 11/03/2013 13:04, Cornelia Huck ha scritto: > >> On Fri, 8 Mar 2013 21:11:13 +0100 > >> Alexander Graf wrote: > >> > >>> On 25.02.2013, at 12:10, Christian Borntraeger wrote: > >>> > >>

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-03-11 Thread Alexander Graf
On 03/11/2013 01:16 PM, Paolo Bonzini wrote: Il 11/03/2013 13:04, Cornelia Huck ha scritto: On Fri, 8 Mar 2013 21:11:13 +0100 Alexander Graf wrote: On 25.02.2013, at 12:10, Christian Borntraeger wrote: On 25/02/13 11:44, Paolo Bonzini wrote: Il 25/02/2013 09:09, Christian Borntraeger ha sc

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 13:04, Cornelia Huck ha scritto: > On Fri, 8 Mar 2013 21:11:13 +0100 > Alexander Graf wrote: > >> >> On 25.02.2013, at 12:10, Christian Borntraeger wrote: >> >>> On 25/02/13 11:44, Paolo Bonzini wrote: Il 25/02/2013 09:09, Christian Borntraeger ha scritto: > Hmm, the old se

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-03-11 Thread Cornelia Huck
On Fri, 8 Mar 2013 21:11:13 +0100 Alexander Graf wrote: > > On 25.02.2013, at 12:10, Christian Borntraeger wrote: > > > On 25/02/13 11:44, Paolo Bonzini wrote: > >> Il 25/02/2013 09:09, Christian Borntraeger ha scritto: > >>> Hmm, the old sequence was > >>> > >>> object_unparent(OBJECT(de

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-03-08 Thread Alexander Graf
On 25.02.2013, at 12:10, Christian Borntraeger wrote: > On 25/02/13 11:44, Paolo Bonzini wrote: >> Il 25/02/2013 09:09, Christian Borntraeger ha scritto: >>> Hmm, the old sequence was >>> >>> object_unparent(OBJECT(dev)); >>> qdev_free(dev) ---+ >>> | >>>

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Christian Borntraeger
On 25/02/13 11:44, Paolo Bonzini wrote: > Il 25/02/2013 09:09, Christian Borntraeger ha scritto: >> Hmm, the old sequence was >> >> object_unparent(OBJECT(dev)); >> qdev_free(dev) ---+ >>| >>V >> ... >> object_unparent(OBJECT(dev)

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Paolo Bonzini
Il 25/02/2013 09:09, Christian Borntraeger ha scritto: > Hmm, the old sequence was > > object_unparent(OBJECT(dev)); > qdev_free(dev) ---+ >| >V > ... >object_unparent(OBJECT(dev)); now the last reference is gone, > object is

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Andreas Färber
Am 25.02.2013 08:55, schrieb Paolo Bonzini: > >> Another thing is, that qdev_free looks now different, some days ago >> it also did an unref. As far as I can see the object_unparent in >> virtio-ccw was always the wrong thing to do. > > object_unparent is "almost" idempotent, i.e. idempotent as

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Christian Borntraeger
On 25/02/13 08:55, Paolo Bonzini wrote: > >> Another thing is, that qdev_free looks now different, some days ago >> it also did an unref. As far as I can see the object_unparent in >> virtio-ccw was always the wrong thing to do. > > object_unparent is "almost" idempotent, i.e. idempotent as long

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Paolo Bonzini
> Another thing is, that qdev_free looks now different, some days ago > it also did an unref. As far as I can see the object_unparent in > virtio-ccw was always the wrong thing to do. object_unparent is "almost" idempotent, i.e. idempotent as long as it does not cause the last reference to go aw

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Christian Borntraeger
On 24/02/13 12:30, Andreas Färber wrote: > Am 22.02.2013 20:01, schrieb Jens Freimann: >> From: Christian Borntraeger >> >> This patch fixes a crash when unplugging a virtio-ccw device. We no >> longer need to do that in virtio-ccw since common code does now >> proper handling. >> >> Signed-off-by

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Andreas Färber
Am 22.02.2013 20:01, schrieb Jens Freimann: > From: Christian Borntraeger > > This patch fixes a crash when unplugging a virtio-ccw device. We no > longer need to do that in virtio-ccw since common code does now > proper handling. > > Signed-off-by: Christian Borntraeger > Signed-off-by: Jens F

[Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-22 Thread Jens Freimann
From: Christian Borntraeger This patch fixes a crash when unplugging a virtio-ccw device. We no longer need to do that in virtio-ccw since common code does now proper handling. Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann --- hw/s390x/virtio-ccw.c | 1 - 1 file changed, 1