Re: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-06-01 Thread Anthony Liguori
On 06/01/2010 04:05 PM, Corentin Chary wrote: A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i< count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary Applied all. Thanks. Regards,

[Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-06-01 Thread Corentin Chary
A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i < count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |9 - 1 files changed, 4 insertions(+), 5 delet

Re: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-06-01 Thread Corentin Chary
On Thu, May 27, 2010 at 4:28 PM, Richard Henderson wrote: > On 05/26/2010 11:21 PM, Corentin Chary wrote: >> -        int rep = 0;                                                    \ >> +        int i = 0, rep = 0;                                             \ > > Dead initialization. > > > r~ >

Re: [Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-05-27 Thread Richard Henderson
On 05/26/2010 11:21 PM, Corentin Chary wrote: > -int rep = 0;\ > +int i = 0, rep = 0; \ Dead initialization. r~

[Qemu-devel] [PATCH 1/3] vnc: tight: don't forget last pixel in tight_encode_indexed_rect

2010-05-26 Thread Corentin Chary
A simple patch would have been to just remove count -= 1, but this one also replace the while (count--) with a for(i = 0; i < count; i++) which I believe is more easy to understand. Signed-off-by: Corentin Chary --- vnc-encoding-tight.c |9 - 1 files changed, 4 insertions(+), 5 delet