Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Alon Levy
> On 03/20/13 17:59, Alon Levy wrote: > >> > I thought we previously discussed this? Just implement a > >> > migration > >> > hook > >> > in the spice code. > > We did and Gerd objected so I sent this to have this discussion > > again, with him. > > migration section != migration hook. > > I thi

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Hans de Goede
Hi, On 03/21/2013 09:27 AM, Hans de Goede wrote: Hi, On 03/20/2013 07:59 PM, Anthony Liguori wrote: Alon Levy writes: Alon Levy writes: Signed-off-by: Alon Levy --- include/char/char.h | 12 qemu-char.c | 7 +++ 2 files changed, 19 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Hans de Goede
Hi, On 03/20/2013 07:59 PM, Anthony Liguori wrote: Alon Levy writes: Alon Levy writes: Signed-off-by: Alon Levy --- include/char/char.h | 12 qemu-char.c | 7 +++ 2 files changed, 19 insertions(+) diff --git a/include/char/char.h b/include/char/char.h index

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Gerd Hoffmann
On 03/20/13 17:59, Alon Levy wrote: >> > I thought we previously discussed this? Just implement a migration >> > hook >> > in the spice code. > We did and Gerd objected so I sent this to have this discussion again, with > him. migration section != migration hook. I think what Anthony asks for i

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Anthony Liguori
Alon Levy writes: >> Alon Levy writes: >> >> > Signed-off-by: Alon Levy >> > --- >> > include/char/char.h | 12 >> > qemu-char.c | 7 +++ >> > 2 files changed, 19 insertions(+) >> > >> > diff --git a/include/char/char.h b/include/char/char.h >> > index 0326b2a..0fdca

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Alon Levy
> Alon Levy writes: > > > Signed-off-by: Alon Levy > > --- > > include/char/char.h | 12 > > qemu-char.c | 7 +++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/include/char/char.h b/include/char/char.h > > index 0326b2a..0fdcaf9 100644 > > --- a/include/ch

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Alon Levy
> Alon Levy writes: > > > Signed-off-by: Alon Levy > > --- > > include/char/char.h | 12 > > qemu-char.c | 7 +++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/include/char/char.h b/include/char/char.h > > index 0326b2a..0fdcaf9 100644 > > --- a/include/ch

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Anthony Liguori
Alon Levy writes: > Signed-off-by: Alon Levy > --- > include/char/char.h | 12 > qemu-char.c | 7 +++ > 2 files changed, 19 insertions(+) > > diff --git a/include/char/char.h b/include/char/char.h > index 0326b2a..0fdcaf9 100644 > --- a/include/char/char.h > +++ b/incl

[Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-20 Thread Alon Levy
Signed-off-by: Alon Levy --- include/char/char.h | 12 qemu-char.c | 7 +++ 2 files changed, 19 insertions(+) diff --git a/include/char/char.h b/include/char/char.h index 0326b2a..0fdcaf9 100644 --- a/include/char/char.h +++ b/include/char/char.h @@ -70,6 +70,7 @@ struc