On 4 December 2012 20:57, Antoine Mathys wrote:
> On 12/04/2012 06:42 PM, Peter Maydell wrote:
>> This looks good as far as the logic goes, but I think we could use some
>> symbolic constants for the 12-hour and PM bits rather than all the literal
>> 0x20 0x40 0x60. thanks -- PMM
>
> I refrained f
On 12/04/2012 06:42 PM, Peter Maydell wrote:
This looks good as far as the logic goes, but I think we could use
some symbolic constants for the 12-hour and PM bits rather than all
the literal 0x20 0x40 0x60. thanks -- PMM
I refrained from using symbolic constants for three reasons:
1. You need
Am 04.12.2012 18:42, schrieb Peter Maydell:
> On 2 December 2012 17:14, Antoine Mathys wrote:
>> Per the datasheet, the mapping between 12 and 24 hours modes is:
>> 0 <-> 12 PM
>> 1-12 <-> 1-12 AM
>> 13-23 <-> 1-11 PM
>>
>> Signed-off-by: Antoine Mathys
>
> This looks go
On 2 December 2012 17:14, Antoine Mathys wrote:
> Per the datasheet, the mapping between 12 and 24 hours modes is:
> 0 <-> 12 PM
> 1-12 <-> 1-12 AM
> 13-23 <-> 1-11 PM
>
> Signed-off-by: Antoine Mathys
This looks good as far as the logic goes, but I think we
could use so
Per the datasheet, the mapping between 12 and 24 hours modes is:
0 <-> 12 PM
1-12 <-> 1-12 AM
13-23 <-> 1-11 PM
Signed-off-by: Antoine Mathys
---
hw/ds1338.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/ds1338.c b/hw/
