Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-09-28 Thread Riku Voipio
On Mon, Jul 13, 2015 at 01:08:02PM -0700, Meador Inge wrote: > On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > > > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h > On second thought, I was following an existing pattern in 'main.c'. Really > fixing

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h On second thought, I was following an existing pattern in 'main.c'. Really fixing this would require changing around 30 other locations too. I think if we

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-08 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h Will fix. Thanks. -- Meador

[Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-06 Thread meadori
From: Meador Inge mead...@codesourcery.com Signed-off-by: Meador Inge mead...@codesourcery.com --- linux-user/main.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index c855bcc..c6ab557 100644 ---

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-06 Thread Laurent Vivier
Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h Le 06/07/2015 20:03, mead...@codesourcery.com a écrit : From: Meador Inge mead...@codesourcery.com Signed-off-by: Meador Inge mead...@codesourcery.com --- linux-user/main.c | 20 ++-- 1 file

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2012-05-07 Thread Andreas Färber
Am 28.03.2012 00:44, schrieb Meador Inge: Signed-off-by: Meador Inge mead...@codesourcery.com --- linux-user/main.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Reviewed-by: Andreas Färber afaer...@suse.de /-F -- SUSE LINUX Products GmbH, Maxfeldstr. 5,

[Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2012-03-27 Thread Meador Inge
Signed-off-by: Meador Inge mead...@codesourcery.com --- linux-user/main.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 962677e..aabce83 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -51,7