Re: [Qemu-devel] [PATCH 1/4] mirror: Do not dereference invalid pointers

2019-09-18 Thread Vladimir Sementsov-Ogievskiy
12.09.2019 16:56, Max Reitz wrote: > mirror_exit_common() may be called twice (if it is called from > mirror_prepare() and fails, it will be called from mirror_abort() > again). > > In such a case, many of the pointers in the MirrorBlockJob object will > already be freed. This can be seen most

Re: [Qemu-devel] [PATCH 1/4] mirror: Do not dereference invalid pointers

2019-09-13 Thread John Snow
On 9/12/19 9:56 AM, Max Reitz wrote: > mirror_exit_common() may be called twice (if it is called from > mirror_prepare() and fails, it will be called from mirror_abort() > again). > > In such a case, many of the pointers in the MirrorBlockJob object will > already be freed. This can be seen

[Qemu-devel] [PATCH 1/4] mirror: Do not dereference invalid pointers

2019-09-12 Thread Max Reitz
mirror_exit_common() may be called twice (if it is called from mirror_prepare() and fails, it will be called from mirror_abort() again). In such a case, many of the pointers in the MirrorBlockJob object will already be freed. This can be seen most reliably for s->target, which is set to NULL