Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-07-02 Thread Paolo Bonzini
Il 26/06/2012 00:01, Anthony Liguori ha scritto: > The various object_property_set_* functions are inconsistent because I > didn't write them. I'm not sure why they take value/name. They should > take name/value IMHO. void object_property_set(Object *obj, Visitor *v, const char *name,

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-26 Thread Markus Armbruster
Anthony Liguori writes: > On 06/25/2012 03:47 PM, Andreas Färber wrote: [...] >> As for convenience, personally I find all these property API signatures >> inconvenient enough that I copy&paste when I add a new one or need to >> look up object.h. The inconsistent or at least unintuitive order of

[Qemu-devel] [PATCH 1/4] object: add object_property_add_bool (v2)

2012-06-25 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- v1 -> v2 - Fix whitespace (Andreas Faerber) --- include/qemu/object.h | 16 ++ qom/object.c | 56 + 2 files changed, 72 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-25 Thread Anthony Liguori
On 06/25/2012 03:47 PM, Andreas Färber wrote: Am 25.06.2012 20:35, schrieb Anthony Liguori: On 06/25/2012 11:32 AM, Andreas Färber wrote: Am 25.06.2012 18:09, schrieb Anthony Liguori: diff --git a/qom/object.c b/qom/object.c index 00bb3b0..1357397 100644 --- a/qom/object.c +++ b/qom/object.c @

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-25 Thread Andreas Färber
Am 25.06.2012 20:35, schrieb Anthony Liguori: > On 06/25/2012 11:32 AM, Andreas Färber wrote: >> Am 25.06.2012 18:09, schrieb Anthony Liguori: >>> diff --git a/qom/object.c b/qom/object.c >>> index 00bb3b0..1357397 100644 >>> --- a/qom/object.c >>> +++ b/qom/object.c >>> @@ -1232,6 +1232,62 @@ void

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-25 Thread Anthony Liguori
On 06/25/2012 11:32 AM, Andreas Färber wrote: Am 25.06.2012 18:09, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori --- include/qemu/object.h | 16 ++ qom/object.c | 56 + 2 files changed, 72 insertions(+), 0 del

Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-25 Thread Andreas Färber
Am 25.06.2012 18:09, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > include/qemu/object.h | 16 ++ > qom/object.c | 56 > + > 2 files changed, 72 insertions(+), 0 deletions(-) > > diff --git a/include/qe

[Qemu-devel] [PATCH 1/4] object: add object_property_add_bool

2012-06-25 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- include/qemu/object.h | 16 ++ qom/object.c | 56 + 2 files changed, 72 insertions(+), 0 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h index 8b17776..3711054 1006