Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-02-06 Thread Fam Zheng
On Sun, 02/02 01:20, Paolo Bonzini wrote: > Il 01/02/2014 15:31, Fam Zheng ha scritto: > >>Why can't it be enabled unconditionally? > >> > > > >So the default behavior is unchanged. > > For the stand-alone executable there is no difference, is there anything > that breaks for the monitor if you al

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-02-01 Thread Paolo Bonzini
Il 01/02/2014 15:31, Fam Zheng ha scritto: Why can't it be enabled unconditionally? So the default behavior is unchanged. For the stand-alone executable there is no difference, is there anything that breaks for the monitor if you always do the accounting? Paolo

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-02-01 Thread Fam Zheng
On Wed, 01/29 16:58, Paolo Bonzini wrote: > Il 29/01/2014 09:40, Fam Zheng ha scritto: > >This option will enable accounting of aio requests. > > > >Signed-off-by: Fam Zheng > >--- > > qemu-io-cmds.c | 35 +++ > > 1 file changed, 31 insertions(+), 4 deletions(-) > >

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-01-29 Thread Paolo Bonzini
Il 29/01/2014 09:40, Fam Zheng ha scritto: This option will enable accounting of aio requests. Signed-off-by: Fam Zheng --- qemu-io-cmds.c | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index f1de24c..d6e

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-01-29 Thread Benoît Canet
Le Wednesday 29 Jan 2014 à 16:40:40 (+0800), Fam Zheng a écrit : > This option will enable accounting of aio requests. > > Signed-off-by: Fam Zheng > --- > qemu-io-cmds.c | 35 +++ > 1 file changed, 31 insertions(+), 4 deletions(-) > > diff --git a/qemu-io-cmds.c

Re: [Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-01-29 Thread Stefan Hajnoczi
On Wed, Jan 29, 2014 at 04:40:40PM +0800, Fam Zheng wrote: > @@ -1442,6 +1453,7 @@ static void aio_read_help(void) > " -P, -- use a pattern to verify read data\n" > " -v, -- dump buffer to standard output\n" > " -q, -- quiet mode, do not show I/O statistics\n" > +" -a, -- account IO\n" > "\n");

[Qemu-devel] [PATCH 1/4] qemu-io: New option "-a" to aio_read and aio_write

2014-01-29 Thread Fam Zheng
This option will enable accounting of aio requests. Signed-off-by: Fam Zheng --- qemu-io-cmds.c | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index f1de24c..d6e20e6 100644 --- a/qemu-io-cmds.c +++ b/qemu-i