Re: [Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Kevin Wolf
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: > error_is_set(&var) is the same as var != NULL, but it takes > whole-program analysis to figure that out. Unnecessarily hard for > optimizers, static checkers, and human readers. Commit 84d18f0 dumbed > it down to obvious, but a few more

Re: [Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben: >> error_is_set(&var) is the same as var != NULL, but it takes >> whole-program analysis to figure that out. Unnecessarily hard for >> optimizers, static checkers, and human readers. Commit 84d18f0 dumbed >> it down

[Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again)

2014-04-24 Thread Markus Armbruster
error_is_set(&var) is the same as var != NULL, but it takes whole-program analysis to figure that out. Unnecessarily hard for optimizers, static checkers, and human readers. Commit 84d18f0 dumbed it down to obvious, but a few more have crept in since, and documentation was overlooked. Dumb these