Il 02/04/2013 19:47, Peter Maydell ha scritto:
> On 2 April 2013 18:26, Paolo Bonzini wrote:
>> I think "a thing the size of a pointer" should be abi_long/ulong. The
>> pointer is not a CPU concept.
>
> Yeah. OTOH type alignment isn't a CPU concept either, so I'm
> a little suspicious of these d
On Tue, Apr 02, 2013 at 05:43:36PM +0100, Peter Maydell wrote:
> On 2 April 2013 15:44, Paolo Bonzini wrote:
> > This is no different from, for example, TARGET_LONG_BITS. It does
> > not belong in configure.
>
> > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> > index 42c36e2..19d4e4c 100644
On 2 April 2013 18:26, Paolo Bonzini wrote:
> I think "a thing the size of a pointer" should be abi_long/ulong. The
> pointer is not a CPU concept.
Yeah. OTOH type alignment isn't a CPU concept either, so I'm
a little suspicious of these defines in general.
-- PMM
Il 02/04/2013 19:17, Peter Maydell ha scritto:
> On 2 April 2013 17:56, Paolo Bonzini wrote:
>> Il 02/04/2013 18:43, Peter Maydell ha scritto:
>>> Doesn't this incorrectly set the long alignment to 8
>>> for ppc64abi32? (Probably similar problem for
>>> sparc32plus and mipsn32. The underlying poin
On 2 April 2013 17:56, Paolo Bonzini wrote:
> Il 02/04/2013 18:43, Peter Maydell ha scritto:
>> Doesn't this incorrectly set the long alignment to 8
>> for ppc64abi32? (Probably similar problem for
>> sparc32plus and mipsn32. The underlying point here is that
>> alignment is an ABI decision and yo
Il 02/04/2013 18:43, Peter Maydell ha scritto:
> On 2 April 2013 15:44, Paolo Bonzini wrote:
>> This is no different from, for example, TARGET_LONG_BITS. It does
>> not belong in configure.
>
>> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
>> index 42c36e2..19d4e4c 100644
>> --- a/target-ppc
On 2 April 2013 15:44, Paolo Bonzini wrote:
> This is no different from, for example, TARGET_LONG_BITS. It does
> not belong in configure.
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 42c36e2..19d4e4c 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -27,6 +27,7 @@
> #
This is no different from, for example, TARGET_LONG_BITS. It does
not belong in configure.
Signed-off-by: Paolo Bonzini
---
configure | 18 --
include/exec/cpu-defs.h | 13 +
target-alpha/cpu.h | 1 +
target-arm/cpu.h| 1 +
target-i386/cp
