Re: [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-06 Thread Philippe Mathieu-Daudé
On 5/6/19 4:39 PM, Laszlo Ersek wrote: > On 05/05/19 22:05, Philippe Mathieu-Daudé wrote: >> The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with >> timing modelled. One year later, the CFI02 model was introduced >> (commit 05ee37ebf630) based on the CFI01 model. As noted in the > >

Re: [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-06 Thread Laszlo Ersek
On 05/05/19 22:05, Philippe Mathieu-Daudé wrote: > The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with > timing modelled. One year later, the CFI02 model was introduced > (commit 05ee37ebf630) based on the CFI01 model. As noted in the You got those commit references backwards, I

Re: [Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-05 Thread Wei Yang
On Sun, May 05, 2019 at 10:05:58PM +0200, Philippe Mathieu-Daudé wrote: >The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with >timing modelled. One year later, the CFI02 model was introduced >(commit 05ee37ebf630) based on the CFI01 model. As noted in the >header, "It does not support

[Qemu-devel] [PATCH 1/5] hw/block/pflash_cfi01: Removed an unused timer

2019-05-05 Thread Philippe Mathieu-Daudé
The 'CFI01' NOR flash was introduced in commit 29133e9a0fff, with timing modelled. One year later, the CFI02 model was introduced (commit 05ee37ebf630) based on the CFI01 model. As noted in the header, "It does not support timings". 12 years later, we never had to model the device timings. Time to