Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp

2017-04-27 Thread Cornelia Huck
On Thu, 27 Apr 2017 20:23:51 +0800 Zihan Yang wrote: > OK, sorry for the confusion, I will give a new patch series. I'm not very > familiar with > the conventions so I wonder if someone could help clarify some principles > for me. > I'd like to replace all the init/exit callback of DeviceClass to

Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp

2017-04-27 Thread Zihan Yang
OK, sorry for the confusion, I will give a new patch series. I'm not very familiar with the conventions so I wonder if someone could help clarify some principles for me. I'd like to replace all the init/exit callback of DeviceClass to realize/unrealize, and convert return type of exit callback of

Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp

2017-04-26 Thread Cornelia Huck
On Wed, 26 Apr 2017 09:42:02 -0500 Eric Blake wrote: > On 04/26/2017 07:53 AM, Zihan Yang wrote: > > Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c > > does nothing, so remove them and convert the callback in SCLPEventClass to > > void. Since there is a NULL check on t

Re: [Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp

2017-04-26 Thread Eric Blake
On 04/26/2017 07:53 AM, Zihan Yang wrote: > Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c > does nothing, so remove them and convert the callback in SCLPEventClass to > void. Since there is a NULL check on the DeviceClass exit callback as > suggested by Frederic Konrad,

[Qemu-devel] [PATCH 1/5] hw/char: remove console_exit function in sclp

2017-04-26 Thread Zihan Yang
Currently, the console_exit function in sclpconsole-lm.c and sclpconsole.c does nothing, so remove them and convert the callback in SCLPEventClass to void. Since there is a NULL check on the DeviceClass exit callback as suggested by Frederic Konrad, it should be safe to remove them. Signed-off-by: