Re: [Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-19 Thread Laszlo Ersek
On 01/19/16 18:04, John Snow wrote: > > > On 01/19/2016 06:48 AM, Paolo Bonzini wrote: >> >> >> On 19/01/2016 05:51, John Snow wrote: >>> +/* Only RESET is allowed to an ATAPI device while BSY and/or DRQ are >>> set. */ >>> +if (s->status & (BUSY_STAT|DRQ_STAT)) { >>> +if (!(val

Re: [Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-19 Thread John Snow
On 01/19/2016 06:48 AM, Paolo Bonzini wrote: > > > On 19/01/2016 05:51, John Snow wrote: >> +/* Only RESET is allowed to an ATAPI device while BSY and/or DRQ are >> set. */ >> +if (s->status & (BUSY_STAT|DRQ_STAT)) { >> +if (!(val == WIN_DEVICE_RESET) && (s->drive_kind == IDE_C

Re: [Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-19 Thread Paolo Bonzini
On 19/01/2016 05:51, John Snow wrote: > +/* Only RESET is allowed to an ATAPI device while BSY and/or DRQ are > set. */ > +if (s->status & (BUSY_STAT|DRQ_STAT)) { > +if (!(val == WIN_DEVICE_RESET) && (s->drive_kind == IDE_CD)) { I was going to complain about Pascal-ish parenthes

[Qemu-devel] [PATCH 1/5] ide: Prohibit RESET on IDE drives

2016-01-18 Thread John Snow
This command is meant for ATAPI devices only, prohibit acknowledging it with a command aborted response when an IDE device is busy. Signed-off-by: John Snow --- hw/ide/core.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index da3baab.