Re: [Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

2018-03-20 Thread Paolo Bonzini
On 20/03/2018 22:46, John Snow wrote: >> } >> -if (s->bus->dma->ops->start_transfer) { >> -s->bus->dma->ops->start_transfer(s->bus->dma); >> +if (!s->bus->dma->ops->start_transfer) { >> +s->end_transfer_func = end_transfer_func; >> +return; >> } >> +s->

Re: [Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

2018-03-20 Thread John Snow
On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > Split the PIO transfer across two callbacks, thus pushing the (possibly > recursive) call to end_transfer_func up one level and out of the > AHCI-specific code. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/ahci.c | 7 ++- > hw/i

[Qemu-devel] [PATCH 1/5] ide: push call to end_transfer_func out of start_transfer callback

2018-02-23 Thread Paolo Bonzini
Split the PIO transfer across two callbacks, thus pushing the (possibly recursive) call to end_transfer_func up one level and out of the AHCI-specific code. Signed-off-by: Paolo Bonzini --- hw/ide/ahci.c | 7 ++- hw/ide/core.c | 9 ++--- include/hw/ide/internal.h