Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-23 Thread Lei Li
On 10/23/2012 02:14 AM, Luiz Capitulino wrote: On Mon, 22 Oct 2012 00:47:57 +0800 Lei Li li...@linux.vnet.ibm.com wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com This patch should be squashed in the next one. More comments below. --- qemu-char.c | 72

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-23 Thread Luiz Capitulino
On Tue, 23 Oct 2012 13:40:13 +0800 Lei Li li...@linux.vnet.ibm.com wrote: +static int cirmem_chr_write(CharDriverState *chr, const uint8_t *buf, int len) +{ +CirMemCharDriver *d = chr-opaque; +int i; + +if (len 0) { +return -1; +} + +/* The size

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Eric Blake
On 10/21/2012 10:47 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..b174da1 100644

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Luiz Capitulino
On Mon, 22 Oct 2012 00:47:57 +0800 Lei Li li...@linux.vnet.ibm.com wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com This patch should be squashed in the next one. More comments below. --- qemu-char.c | 72 +++ 1 files

Re: [Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-22 Thread Lei Li
On 10/22/2012 10:08 PM, Eric Blake wrote: On 10/21/2012 10:47 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c

[Qemu-devel] [PATCH 1/5] qemu-char: Add new char backend CircularMemCharDriver

2012-10-21 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qemu-char.c | 72 +++ 1 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..b174da1 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2588,6