Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-09 Thread Peter Maydell
On 9 September 2012 10:24, Aurelien Jarno wrote: > My idea was that negating both the product and c is equivalent to > negating the result, so there is no need to allow all of them > independent. This is the kind of statement about floating point arithmetic that sounds plausible but turns out to

Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-09 Thread Aurelien Jarno
On Sun, Sep 09, 2012 at 10:47:52AM +0100, Peter Maydell wrote: > On 9 September 2012 10:24, Aurelien Jarno wrote: > > On Sun, Sep 09, 2012 at 01:40:52AM +0400, Max Filippov wrote: > >> I've also stumbled upon this bug, have a patch for it in the xtensa tree. > >> I guess that the interface was des

Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-09 Thread Peter Maydell
On 9 September 2012 10:24, Aurelien Jarno wrote: > On Sun, Sep 09, 2012 at 01:40:52AM +0400, Max Filippov wrote: >> I've also stumbled upon this bug, have a patch for it in the xtensa tree. >> I guess that the interface was designed to allow combining these flags, why >> don't just make them indep

Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-09 Thread Aurelien Jarno
On Sun, Sep 09, 2012 at 01:40:52AM +0400, Max Filippov wrote: > On Sun, Sep 9, 2012 at 1:12 AM, Aurelien Jarno wrote: > > float{32,64}_muladd takes an enum as a parameter, and not flags. It > > means the parameter should be checked with == test instead of &. > > > > Cc: Peter Maydell > > Signed-o

Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-08 Thread Peter Maydell
On 8 September 2012 22:40, Max Filippov wrote: > On Sun, Sep 9, 2012 at 1:12 AM, Aurelien Jarno wrote: >> float{32,64}_muladd takes an enum as a parameter, and not flags. It >> means the parameter should be checked with == test instead of &. > > I've also stumbled upon this bug, have a patch for

Re: [Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-08 Thread Max Filippov
On Sun, Sep 9, 2012 at 1:12 AM, Aurelien Jarno wrote: > float{32,64}_muladd takes an enum as a parameter, and not flags. It > means the parameter should be checked with == test instead of &. > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno > --- Hi Aurelien, I've also stumbled upon this b

[Qemu-devel] [PATCH 1/5] softfloat: fix float{32, 64}_muladd options

2012-09-08 Thread Aurelien Jarno
float{32,64}_muladd takes an enum as a parameter, and not flags. It means the parameter should be checked with == test instead of &. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- fpu/softfloat.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fpu/softflo