Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-21 Thread Igor Mammedov
On Tue, 20 Jan 2015 16:45:19 -0600 Greg Bellows wrote: > On Tue, Jan 20, 2015 at 10:25 AM, Igor Mammedov wrote: > > On Tue, 20 Jan 2015 16:08:09 + > > Peter Maydell wrote: > > > >> On 20 January 2015 at 15:59, Igor Mammedov wrote: > >> > On Tue, 20 Jan 2015 15:34:23 + > >> > Peter Mayd

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-21 Thread Alex Bennée
Greg Bellows writes: > Thanks Alex comments inline > >> >> Aren't we leaking here? strtok returns the next token (or NULL) so don't >> we loose the original ptr? >> >> > ​As I understand it, strtok uses static pointers to track the location > within an existing string rather than allocating

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Greg Bellows
On Tue, Jan 20, 2015 at 10:25 AM, Igor Mammedov wrote: > On Tue, 20 Jan 2015 16:08:09 + > Peter Maydell wrote: > >> On 20 January 2015 at 15:59, Igor Mammedov wrote: >> > On Tue, 20 Jan 2015 15:34:23 + >> > Peter Maydell wrote: >> > >> >> On 20 January 2015 at 15:22, Igor Mammedov wrot

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 16:08:09 + Peter Maydell wrote: > On 20 January 2015 at 15:59, Igor Mammedov wrote: > > On Tue, 20 Jan 2015 15:34:23 + > > Peter Maydell wrote: > > > >> On 20 January 2015 at 15:22, Igor Mammedov wrote: > >> > Please do not use legacy +-feature format and support on

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 15:59, Igor Mammedov wrote: > On Tue, 20 Jan 2015 15:34:23 + > Peter Maydell wrote: > >> On 20 January 2015 at 15:22, Igor Mammedov wrote: >> > Please do not use legacy +-feature format and support only foo=val format. >> > Other targets have it only for to being able s

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 09:34:39 -0600 Greg Bellows wrote: > On Tue, Jan 20, 2015 at 9:22 AM, Igor Mammedov wrote: > > > On Mon, 19 Jan 2015 16:30:17 -0600 > > Greg Bellows wrote: > > > > > Adds a CPU feature parsing function and assigns to the CPU class. The > > only > > > feature added was "-aa

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Eduardo Habkost
On Tue, Jan 20, 2015 at 09:34:39AM -0600, Greg Bellows wrote: > On Tue, Jan 20, 2015 at 9:22 AM, Igor Mammedov wrote: > > > On Mon, 19 Jan 2015 16:30:17 -0600 > > Greg Bellows wrote: > > > > > Adds a CPU feature parsing function and assigns to the CPU class. The > > only > > > feature added was

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Tue, 20 Jan 2015 15:34:23 + Peter Maydell wrote: > On 20 January 2015 at 15:22, Igor Mammedov wrote: > > Please do not use legacy +-feature format and support only foo=val format. > > Other targets have it only for to being able support legacy setups > > which use +- format. > > I though

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Greg Bellows
On Tue, Jan 20, 2015 at 9:22 AM, Igor Mammedov wrote: > On Mon, 19 Jan 2015 16:30:17 -0600 > Greg Bellows wrote: > > > Adds a CPU feature parsing function and assigns to the CPU class. The > only > > feature added was "-aarch64" which disabled the AArch64 execution state > on a > > 64-bit ARM C

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Peter Maydell
On 20 January 2015 at 15:22, Igor Mammedov wrote: > Please do not use legacy +-feature format and support only foo=val format. > Other targets have it only for to being able support legacy setups > which use +- format. I thought this was the standard format for CPU features. Do you have an exampl

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Igor Mammedov
On Mon, 19 Jan 2015 16:30:17 -0600 Greg Bellows wrote: > Adds a CPU feature parsing function and assigns to the CPU class. The only > feature added was "-aarch64" which disabled the AArch64 execution state on a > 64-bit ARM CPU. > > Also adds stripping of features from CPU model string in acqui

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Greg Bellows
Thanks Alex comments inline On Tue, Jan 20, 2015 at 8:19 AM, Alex Bennée wrote: > > Greg Bellows writes: > > > Adds a CPU feature parsing function and assigns to the CPU class. The > only > > feature added was "-aarch64" which disabled the AArch64 execution state > on a > > 64-bit ARM CPU.

Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-20 Thread Alex Bennée
Greg Bellows writes: > Adds a CPU feature parsing function and assigns to the CPU class. The only > feature added was "-aarch64" which disabled the AArch64 execution state on a > 64-bit ARM CPU. > > Also adds stripping of features from CPU model string in acquiring the ARM CPU > by name. > > Si

[Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing

2015-01-19 Thread Greg Bellows
Adds a CPU feature parsing function and assigns to the CPU class. The only feature added was "-aarch64" which disabled the AArch64 execution state on a 64-bit ARM CPU. Also adds stripping of features from CPU model string in acquiring the ARM CPU by name. Signed-off-by: Greg Bellows --- target