Re: [Qemu-devel] [PATCH 1/5] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page()

2016-05-16 Thread Sergey Fedorov
On 16/05/16 20:15, Peter Maydell wrote: > On 16 May 2016 at 18:13, Sergey Fedorov wrote: >> On 16/05/16 19:09, Peter Maydell wrote: >>> @@ -1996,7 +1997,10 @@ int page_unprotect(target_ulong address, uintptr_t >>> pc, void *puc) >>> >>> /* and since the content will be modified, we m

Re: [Qemu-devel] [PATCH 1/5] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page()

2016-05-16 Thread Peter Maydell
On 16 May 2016 at 18:13, Sergey Fedorov wrote: > On 16/05/16 19:09, Peter Maydell wrote: >> @@ -1996,7 +1997,10 @@ int page_unprotect(target_ulong address, uintptr_t >> pc, void *puc) >> >> /* and since the content will be modified, we must invalidate >> the correspon

Re: [Qemu-devel] [PATCH 1/5] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page()

2016-05-16 Thread Sergey Fedorov
On 16/05/16 19:09, Peter Maydell wrote: > The user-mode-only function tb_invalidate_phys_page() is only > called from two places: > * page_unprotect(), which passes in a non-zero pc, a puc pointer >and the value 'true' for the locked argument > * page_set_flags(), which passes in a zero pc, a

[Qemu-devel] [PATCH 1/5] translate-all.c: Don't pass puc, locked to tb_invalidate_phys_page()

2016-05-16 Thread Peter Maydell
The user-mode-only function tb_invalidate_phys_page() is only called from two places: * page_unprotect(), which passes in a non-zero pc, a puc pointer and the value 'true' for the locked argument * page_set_flags(), which passes in a zero pc, a NULL puc pointer and a 'false' locked argument