Re: [Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-13 Thread Gerd Hoffmann
On Mo, 2015-07-13 at 11:00 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 09:53:43AM +0200, Gerd Hoffmann wrote: > > On Mo, 2015-07-13 at 10:36 +0300, Michael S. Tsirkin wrote: > > > On Mon, Jul 13, 2015 at 01:46:47PM +0800, Jason Wang wrote: > > > > We abort on unaligned read/write in

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-13 Thread Jason Wang
On 07/13/2015 03:36 PM, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 01:46:47PM +0800, Jason Wang wrote: >> We abort on unaligned read/write in >> virtio_address_space_read()/write() but since len in under control of >> guest so qemu will simply crash when booting a modern guest (guest is

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 09:53:43AM +0200, Gerd Hoffmann wrote: > On Mo, 2015-07-13 at 10:36 +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 13, 2015 at 01:46:47PM +0800, Jason Wang wrote: > > > We abort on unaligned read/write in > > > virtio_address_space_read()/write() but since len in under con

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-13 Thread Gerd Hoffmann
On Mo, 2015-07-13 at 10:36 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 01:46:47PM +0800, Jason Wang wrote: > > We abort on unaligned read/write in > > virtio_address_space_read()/write() but since len in under control of > > guest so qemu will simply crash when booting a modern guest

Re: [Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 01:46:47PM +0800, Jason Wang wrote: > We abort on unaligned read/write in > virtio_address_space_read()/write() but since len in under control of > guest so qemu will simply crash when booting a modern guest (guest is > try to read when len is zero). > read. How can len be

[Qemu-devel] [PATCH 1/5] virtio-pci: ignore unaligned read/write in virtio_address_space_read()/write()

2015-07-12 Thread Jason Wang
We abort on unaligned read/write in virtio_address_space_read()/write() but since len in under control of guest so qemu will simply crash when booting a modern guest (guest is try to read when len is zero). Fix this by ignoring unaligned write or read. Fixes 1e40356ce5f6ccfa0bb57104a533c62952c560c