Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-03-11 Thread Richard Henderson
On 03/11/2010 03:11 AM, Aurelien Jarno wrote: >> +/* ??? MIPS64 no doubt has a larger address space. */ >> +#define TARGET_PHYS_ADDR_SPACE_BITS 32 >> +#define TARGET_VIRT_ADDR_SPACE_BITS 32 >> + > > In 32-bit mode, TARGET_VIRT_ADDR_SPACE_BITS is 32 bits, and > TARGET_PHYS_ADDR_SPACE_BITS is 36 bi

Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-03-11 Thread Aurelien Jarno
On Wed, Mar 10, 2010 at 02:33:23PM -0800, Richard Henderson wrote: > Removes a set of ifdefs from exec.c. > > Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other > than Alpha. This will be used for page_find_alloc, which is > supposed to be using virtual addresses in the first place. > >

[Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-03-10 Thread Richard Henderson
Removes a set of ifdefs from exec.c. Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other than Alpha. This will be used for page_find_alloc, which is supposed to be using virtual addresses in the first place. Signed-off-by: Richard Henderson --- exec.c | 17 --

Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-12 Thread Richard Henderson
On 02/12/2010 12:01 PM, Blue Swirl wrote: +#ifdef TARGET_ABI32 +# define TARGET_VIRT_ADDR_SPACE_BITS 32 +#else +# define TARGET_VIRT_ADDR_SPACE_BITS 64 +#endif I'd suppose this change applies to all targets with ABI32, not just PPC. Indeed. Odd that sparc32plus didn't yield errors building,

Re: [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-12 Thread Blue Swirl
On Fri, Feb 12, 2010 at 12:20 AM, Richard Henderson wrote: > Removes a set of ifdefs from exec.c. > > Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other > than Alpha.  This will be used for page_find_alloc, which is > supposed to be using virtual addresses in the first place. > --- >  exe

[Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h.

2010-02-11 Thread Richard Henderson
Removes a set of ifdefs from exec.c. Introduce TARGET_VIRT_ADDR_SPACE_BITS for all targets other than Alpha. This will be used for page_find_alloc, which is supposed to be using virtual addresses in the first place. --- exec.c | 17 - target-alpha/cpu.h |