Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-18 Thread Eric Blake
On 09/18/2014 05:53 AM, Kevin Wolf wrote: > Am 18.09.2014 um 13:04 hat Markus Armbruster geschrieben: >> Before this patch, QAPI type BlockdevCacheOptions is used only as a >> member of BlockdevOptionsBase. >> >> BlockdevOptionsBase is a collection configuration settings. >> Consequently, it's a co

Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-18 Thread Markus Armbruster
Kevin Wolf writes: > Am 18.09.2014 um 13:04 hat Markus Armbruster geschrieben: >> Before this patch, QAPI type BlockdevCacheOptions is used only as a >> member of BlockdevOptionsBase. >> >> BlockdevOptionsBase is a collection configuration settings. >> Consequently, it's a complex type whose mem

Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-18 Thread Kevin Wolf
Am 18.09.2014 um 13:04 hat Markus Armbruster geschrieben: > Before this patch, QAPI type BlockdevCacheOptions is used only as a > member of BlockdevOptionsBase. > > BlockdevOptionsBase is a collection configuration settings. > Consequently, it's a complex type whose members are optional exactly >

Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-18 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >> @@ -335,6 +336,13 @@ void hmp_info_block(Monitor *mon, const QDict *qdict) >> continue; >> } >> >> +inserted = info->value->inserted; >> + >> +monitor_printf(mon, "Cache mode: %s%s%s\n", >>

Re: [Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-18 Thread Markus Armbruster
Kevin Wolf writes: > Signed-off-by: Kevin Wolf > --- > block/qapi.c | 10 ++ > hmp.c | 8 > qapi/block-core.json | 4 +++- > tests/qemu-iotests/051.out | 1 + > tests/qemu-iotests/067.out | 10 +- > 5 files changed, 27 inserti

[Qemu-devel] [PATCH 1/6] block/qapi: Add cache information to query-block

2014-09-16 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/qapi.c | 10 ++ hmp.c | 8 qapi/block-core.json | 4 +++- tests/qemu-iotests/051.out | 1 + tests/qemu-iotests/067.out | 10 +- 5 files changed, 27 insertions(+), 6 deletions(-) diff --git a/