Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 19:27, Laszlo Ersek wrote: >> Based upon this what do you think the best solution would be? > > > if you apply patch #2 without patch #1, then the above SIGSEGV will hit > on all fw_cfg using targets / machine types, not just > qemu-system-sparc64. The reason is that, after patch #2

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Laszlo Ersek
Hi Mark, On 06/12/17 13:45, Mark Cave-Ayland wrote: > On 12/06/17 12:20, Igor Mammedov wrote: > >> On Sat, 10 Jun 2017 13:30:16 +0100 >> Mark Cave-Ayland wrote: >> >>> Signed-off-by: Mark Cave-Ayland >>> --- >>> hw/nvram/fw_cfg.c | 14 ++ >>> 1 file changed, 10 insertions(+), 4 d

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Mark Cave-Ayland
On 12/06/17 12:20, Igor Mammedov wrote: > On Sat, 10 Jun 2017 13:30:16 +0100 > Mark Cave-Ayland wrote: > >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/nvram/fw_cfg.c | 14 ++ >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-12 Thread Igor Mammedov
On Sat, 10 Jun 2017 13:30:16 +0100 Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/nvram/fw_cfg.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c > index 316fca9..144e0c6 100644 > --- a/hw/nvr

Re: [Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-10 Thread Philippe Mathieu-Daudé
On 06/10/2017 09:30 AM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9..144e0c6 10064

[Qemu-devel] [PATCH 1/6] fw_cfg: move initialisation of FWCfgState into instance_init

2017-06-10 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/nvram/fw_cfg.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 316fca9..144e0c6 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -1017,6 +1017,15 @@ FWCfgState *fw_cfg