Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded

2017-12-08 Thread Eduardo Habkost
On Thu, Dec 07, 2017 at 06:14:48PM +, Peter Maydell wrote: > We were passing a NULL error pointer to the object_property_set_bool() > call that realizes the CPU object. This meant that we wouldn't detect > failure, and would plough blindly on to crash later trying to use a > NULL CPU object poi

[Qemu-devel] [PATCH 1/6] hw/arm/virt: Check that the CPU realize method succeeded

2017-12-07 Thread Peter Maydell
We were passing a NULL error pointer to the object_property_set_bool() call that realizes the CPU object. This meant that we wouldn't detect failure, and would plough blindly on to crash later trying to use a NULL CPU object pointer. Detect errors and fail instead. In particular, this will be nece