Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2019-03-05 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 12/10/18 5:02 PM, Laszlo Ersek wrote: > On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: >> Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). >> There is no need to null check it. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/virt.c | 4 >

Re: [Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2018-12-10 Thread Laszlo Ersek
On 12/07/18 18:03, Philippe Mathieu-Daudé wrote: > Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). > There is no need to null check it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/arm/vi

[Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios()

2018-12-07 Thread Philippe Mathieu-Daudé
Since af1f60a4022, the fw_cfg field is always created in machvirt_init(). There is no need to null check it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index f69e7eb399..36303ed59c 100644 --- a/hw/a