Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-12 Thread Daniel P . Berrangé
On Mon, Mar 12, 2018 at 12:43:47PM +0100, Kevin Wolf wrote: > Am 12.03.2018 um 12:35 hat Daniel P. Berrangé geschrieben: > > On Fri, Mar 09, 2018 at 06:27:08PM +0100, Kevin Wolf wrote: > > > The crypto driver used to create the image file in a callback from the > > > crypto subsystem. If we want

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-12 Thread Kevin Wolf
Am 12.03.2018 um 12:35 hat Daniel P. Berrangé geschrieben: > On Fri, Mar 09, 2018 at 06:27:08PM +0100, Kevin Wolf wrote: > > The crypto driver used to create the image file in a callback from the > > crypto subsystem. If we want to implement .bdrv_co_create, this needs to > > go away because that

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-12 Thread Daniel P . Berrangé
On Fri, Mar 09, 2018 at 06:27:08PM +0100, Kevin Wolf wrote: > The crypto driver used to create the image file in a callback from the > crypto subsystem. If we want to implement .bdrv_co_create, this needs to > go away because that callback will get a reference to an already > existing block node.

Re: [Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-09 Thread Eric Blake
On 03/09/2018 11:27 AM, Kevin Wolf wrote: The crypto driver used to create the image file in a callback from the crypto subsystem. If we want to implement .bdrv_co_create, this needs to go away because that callback will get a reference to an already existing block node. Move the image file

[Qemu-devel] [PATCH 1/6] luks: Separate image file creation from formatting

2018-03-09 Thread Kevin Wolf
The crypto driver used to create the image file in a callback from the crypto subsystem. If we want to implement .bdrv_co_create, this needs to go away because that callback will get a reference to an already existing block node. Move the image file creation to block_crypto_create_generic().