> From: Janeczek, Craig
>
> Yes, both the comment and enum should be updated.
OK, this will be fixed in v2.
Thanks,
Aleksandar
Yes, both the comment and enum should be updated.
-Original Message-
From: Aleksandar Markovic
Sent: Thursday, December 27, 2018 2:23 PM
To: Janeczek, Craig ; Stefan Markovic
; Aleksandar Markovic ;
qemu-devel@nongnu.org
Subject: Re: [PATCH 1/6] target/mips: MXU: Add missing opcodes/de
> From: Janeczek, Craig
> Sent: Thursday, December 27, 2018 7:50 PM
> To: Aleksandar Markovic; Stefan Markovic; Aleksandar Markovic;
> qemu-devel@nongnu.org
> Subject: RE: [PATCH 1/6] target/mips: MXU: Add missing opcodes/decoding for
> LX* instructions
>
> Yes built a binary testing these inst
Yes built a binary testing these instructions and ran it against HW along with
a qemu binary with your patches. The opcodes align with what I mentioned in the
email.
-Original Message-
From: Aleksandar Markovic
Sent: Thursday, December 27, 2018 1:44 PM
To: Janeczek, Craig ; Stefan Mark
> > @@ -1663,12 +1663,21 @@ enum {
> >* │ 20..18
> >* ├─ 100111 ─ OPC_MXU__POOL16 ─┬─ 000 ─ OPC_MXU_D32SARW
> >* │├─ 001 ─ OPC_MXU_S32ALN
> > - * ├─ 101000 ─ OPC_MXU_LXB ├─ 010 ─ OPC_MXU_S
On 17.12.18. 21:04, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Add missing opcodes and decoding engine for LXB, LXH, LXW, LXBU, and
> LXHU instructions. They were for some reason forgotten in previous
> commits. The MXU opcode list and decoding engine should be now
> complete.
>
On 17.12.18. 21:04, Aleksandar Markovic wrote:
> From: Aleksandar Markovic
>
> Add missing opcodes and decoding engine for LXB, LXH, LXW, LXBU,
> and LXHU instructions. They were for some reason forgotten in
> previous commits. The MXU opcode list and decoding engine should
> be now complete.
>
>
From: Aleksandar Markovic
Add missing opcodes and decoding engine for LXB, LXH, LXW, LXBU,
and LXHU instructions. They were for some reason forgotten in
previous commits. The MXU opcode list and decoding engine should
be now complete.
Signed-off-by: Aleksandar Markovic
---
target/mips/translat
