Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Igor Mammedov
On 02/17/2012 06:02 PM, Igor Mammedov wrote: On 02/16/2012 01:42 PM, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Andreas Färber
Am 24.02.2012 14:05, schrieb Igor Mammedov: On 02/17/2012 06:02 PM, Igor Mammedov wrote: So I'd rather drop ICC patch and try your approach with CPU links, I see no point in introducing new bus providing we have an alternative model and existing bus for the task. I've looked at device_add

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 02:30 PM, Andreas Färber wrote: SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so I'd rather not base a new series on that. Not sure about that. I haven't understood well the scope of the series, but I think it only converted buses to QOM, it didn't kill

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Anthony Liguori
On 02/24/2012 07:40 AM, Paolo Bonzini wrote: On 02/24/2012 02:30 PM, Andreas Färber wrote: SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so I'd rather not base a new series on that. Not sure about that. I haven't understood well the scope of the series, but I think it

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 02:47 PM, Anthony Liguori wrote: I agree with you in principle, but in practice, there is not obvious way to serialize gpio_in/gpio_out via Visitors. Finding some way to do it as an integer is clearly wrong IMHO. %s/gpio_in[%d] % (object_get_canonical_path(...), opaque-n) is

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Anthony Liguori
On 02/24/2012 07:50 AM, Paolo Bonzini wrote: On 02/24/2012 02:47 PM, Anthony Liguori wrote: I agree with you in principle, but in practice, there is not obvious way to serialize gpio_in/gpio_out via Visitors. Finding some way to do it as an integer is clearly wrong IMHO. %s/gpio_in[%d] %

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-17 Thread Igor Mammedov
On 02/16/2012 01:42 PM, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support APIC hot-plug feature. This is repost of original patch for qemu-kvm rebased on current

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-16 Thread Anthony Liguori
On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support APIC hot-plug feature. This is repost of original

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:42, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support APIC

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-16 Thread Anthony Liguori
On 02/16/2012 06:50 AM, Jan Kiszka wrote: On 2012-02-16 13:42, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-16 Thread Jan Kiszka
On 2012-02-16 13:59, Anthony Liguori wrote: On 02/16/2012 06:50 AM, Jan Kiszka wrote: On 2012-02-16 13:42, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER

[Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-15 Thread Igor Mammedov
Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to hold APIC,instead of sysbus. So we can support APIC hot-plug feature. This is repost of original patch for qemu-kvm rebased on current qemu: