Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-11 Thread Stefano Stabellini
On Wed, 9 Dec 2015, Eduardo Habkost wrote: > On Tue, Dec 08, 2015 at 03:07:22PM +0100, Gerd Hoffmann wrote: > > rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, > > use it for both xen and non-xen init. > > > > Signed-off-by: Gerd Hoffmann > > --- > > hw/i386/pc_piix.c | 11

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-09 Thread Eduardo Habkost
On Tue, Dec 08, 2015 at 03:07:22PM +0100, Gerd Hoffmann wrote: > rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, > use it for both xen and non-xen init. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_piix.c | 11 +-- > 1 file changed, 5 insertions(+), 6

[Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Gerd Hoffmann
rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, use it for both xen and non-xen init. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Marcel Apfelbaum
On 12/08/2015 04:07 PM, Gerd Hoffmann wrote: rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, use it for both xen and non-xen init. Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-08 Thread Gerd Hoffmann
> Hi Gerd, > > A quick question, does IGD_PASSTHROUGH makes sense for compat machine types? Unlikely to be used in practice, but I don't feel like creating different initialization code paths because of that ... > On the same topic, does machine->igd_gfx_passthru makes sense for all machine >