Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 13/11/2017 17:38, Cornelia Huck wrote: On Mon, 13 Nov 2017 16:36:34 +0100 Pierre Morel wrote: On 09/11/2017 20:20, Cornelia Huck wrote: On Thu, 9 Nov 2017 15:55:46 -0300 Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pie

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Cornelia Huck
On Mon, 13 Nov 2017 16:36:34 +0100 Pierre Morel wrote: > On 09/11/2017 20:20, Cornelia Huck wrote: > > On Thu, 9 Nov 2017 15:55:46 -0300 > > Philippe Mathieu-Daudé wrote: > > > >> On 11/09/2017 01:38 PM, Cornelia Huck wrote: > >>> On Tue, 7 Nov 2017 18:24:33 +0100 > >>> Pierre Morel wrote

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 20:20, Cornelia Huck wrote: On Thu, 9 Nov 2017 15:55:46 -0300 Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor t

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-09 Thread Cornelia Huck
On Thu, 9 Nov 2017 15:55:46 -0300 Philippe Mathieu-Daudé wrote: > On 11/09/2017 01:38 PM, Cornelia Huck wrote: > > On Tue, 7 Nov 2017 18:24:33 +0100 > > Pierre Morel wrote: > > > >> There are two places where the same endianness conversion > >> is done. > >> Let's factor this out into a stat

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-09 Thread Philippe Mathieu-Daudé
On 11/09/2017 01:38 PM, Cornelia Huck wrote: > On Tue, 7 Nov 2017 18:24:33 +0100 > Pierre Morel wrote: > >> There are two places where the same endianness conversion >> is done. >> Let's factor this out into a static function. >> >> Signed-off-by: Pierre Morel >> Reviewed-by: Yi Min Zhao >> --

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-09 Thread Cornelia Huck
On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: > There are two places where the same endianness conversion > is done. > Let's factor this out into a static function. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > --- > hw/s390x/s390-pci-inst.c | 58 > +++

[Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-07 Thread Pierre Morel
There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 58 ++-- 1 file changed, 32 insertions(+), 26 deletion