Re: [Qemu-devel] [PATCH 1.0] configure: pass suffix to 'sed -i' command

2011-11-10 Thread Peter Maydell
On 10 November 2011 18:59, Pavel Borzenkov wrote: > On Nov 10, 2011, at 10:18 PM, Peter Maydell wrote: >> sed -i isn't POSIX; it would be nicer not to use it at all really. > > I was trying to do minimal changes to the code. > Do you know sed implementations that do not support '-i'? busybox sed

Re: [Qemu-devel] [PATCH 1.0] configure: pass suffix to 'sed -i' command

2011-11-10 Thread Pavel Borzenkov
On Nov 10, 2011, at 10:18 PM, Peter Maydell wrote: > On 10 November 2011 18:03, Pavel Borzenkov wrote: >> diff --git a/configure b/configure >> index 401d9a6..b83640e 100755 >> --- a/configure >> +++ b/configure >> @@ -1968,7 +1968,7 @@ EOF >> if compile_prog "" "" ; then >> attr=yes >>

Re: [Qemu-devel] [PATCH 1.0] configure: pass suffix to 'sed -i' command

2011-11-10 Thread Peter Maydell
On 10 November 2011 18:03, Pavel Borzenkov wrote: > diff --git a/configure b/configure > index 401d9a6..b83640e 100755 > --- a/configure > +++ b/configure > @@ -1968,7 +1968,7 @@ EOF >   if compile_prog "" "" ; then >     attr=yes >   # Older distros have , and need -lattr: > -  elif sed -i s,sys/

[Qemu-devel] [PATCH 1.0] configure: pass suffix to 'sed -i' command

2011-11-10 Thread Pavel Borzenkov
BSD sed always requires a suffix to be passed when '-i' switch is used. In GNU sed this suffix is optional. Due to this, configure prints the following error when runs on Mac OS X: sed: 1: "/var/folders/r_/1g8ws8s ...": invalid command code f Signed-off-by: Pavel Borzenkov --- configure |2