On 11/25/2011 02:23 AM, Paolo Bonzini wrote:
On 11/24/2011 06:55 PM, Michael S. Tsirkin wrote:
> Could some backend make it a hard failure?
I don't see how, there's no way to report a failure from
an io port write.
You can exit(1), or fall back to a restricted set of features like we do for
B
On Fri, Nov 25, 2011 at 09:23:42AM +0100, Paolo Bonzini wrote:
> On 11/24/2011 06:55 PM, Michael S. Tsirkin wrote:
> >> Could some backend make it a hard failure?
> >
> >I don't see how, there's no way to report a failure from
> >an io port write.
>
> You can exit(1), or fall back to a restricted
On 11/24/2011 06:55 PM, Michael S. Tsirkin wrote:
> Could some backend make it a hard failure?
I don't see how, there's no way to report a failure from
an io port write.
You can exit(1), or fall back to a restricted set of features like we do
for BAD_FEATURE. BAD_FEATURE is a special case o
On Thu, Nov 24, 2011 at 05:49:23PM +0100, Paolo Bonzini wrote:
> On 11/24/2011 05:42 PM, Michael S. Tsirkin wrote:
> >Most users ignore the return value anyway,
> >and virtio_load needs to look at supported features
> >mask for the diagnostic anyway. So let's use virtio_set_features
> >void.
>
> C
On 11/24/2011 05:42 PM, Michael S. Tsirkin wrote:
Most users ignore the return value anyway,
and virtio_load needs to look at supported features
mask for the diagnostic anyway. So let's use virtio_set_features
void.
Could some backend make it a hard failure? If I understand correctly,
this wo
On Thu, Nov 24, 2011 at 01:28:52PM +0100, Paolo Bonzini wrote:
> vdev->guest_features is not masking features that are not supported by
> the guest. Fix this by introducing a common wrapper to be used by all
> virtio bus implementations.
>
> Signed-off-by: Paolo Bonzini
Yes, while I can't point
vdev->guest_features is not masking features that are not supported by
the guest. Fix this by introducing a common wrapper to be used by all
virtio bus implementations.
Signed-off-by: Paolo Bonzini
---
hw/s390-virtio-bus.c |5 +
hw/syborg_virtio.c |4 +---
hw/virtio-pci.c |
