Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Markus Armbruster
Avi Kivity writes: > On 11/27/2012 10:34 AM, Paolo Bonzini wrote: >> Some versions of GCC require insane (>2GB) amounts of memory >> to compile translate.o. As a countermeasure, compile it >> with -O1. This should fix the buildbot failure for >> default_x86_64_fedora16. >> >> Signed-off-by: Pa

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 17:49, Markus Armbruster ha scritto: >>> +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS)) >>> + >> >> This may change some string argument in CFLAGS, for example an argument >> to -I. >> >> How about: >> >> CFLAGS_opt = -O2 >> CFLAGS += $(CFLAGS_opt) >> ... >> %/transla

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Andreas Färber
Am 27.11.2012 14:49, schrieb 陳韋任 (Wei-Ren Chen): > On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: >> On 11/27/12 14:24, Peter Maydell wrote: >>> On 27 November 2012 08:34, Paolo Bonzini wrote: Some versions of GCC require insane (>2GB) amounts of memory to compile transla

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 16:53, Avi Kivity ha scritto: > This may change some string argument in CFLAGS, for example an argument > to -I. > > How about: > > CFLAGS_opt = -O2 > CFLAGS += $(CFLAGS_opt) > ... > %/translate.o: CFLAGS_opt = -O1 Not possible because CFLAGS comes from configure, but anywa

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Avi Kivity
On 11/27/2012 10:34 AM, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory > to compile translate.o. As a countermeasure, compile it > with -O1. This should fix the buildbot failure for > default_x86_64_fedora16. > > Signed-off-by: Paolo Bonzini > --- > Makefil

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:49, 陳韋任 (Wei-Ren Chen) ha scritto: >> > It isn't that simple. It's Fedora 17 with gcc 4.7.2 which runs oom >> > while compiling translate.c > Even apply Peter's suggestion? Do all gcc 4.7.2 on various platform > have the same problem, or it only happen on Fedora 17. All. It is

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 14:46, Peter Maydell ha scritto: > On 27 November 2012 13:45, Gerd Hoffmann wrote: >> On 11/27/12 14:24, Peter Maydell wrote: >>> This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and >>> trunk a year ago). Use a newer gcc, or a 64 bit build system >>> with a reasonable amoun

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Wei-Ren Chen
On Tue, Nov 27, 2012 at 02:45:07PM +0100, Gerd Hoffmann wrote: > On 11/27/12 14:24, Peter Maydell wrote: > > On 27 November 2012 08:34, Paolo Bonzini wrote: > >> Some versions of GCC require insane (>2GB) amounts of memory > >> to compile translate.o. As a countermeasure, compile it > >> with -O1

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 13:45, Gerd Hoffmann wrote: > On 11/27/12 14:24, Peter Maydell wrote: >> This is a well known bug in old gcc (ie fixed in 4.5, 4.6 and >> trunk a year ago). Use a newer gcc, or a 64 bit build system >> with a reasonable amount of RAM, or as a workaround apply some >> suitable c

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
On 11/27/12 14:24, Peter Maydell wrote: > On 27 November 2012 08:34, Paolo Bonzini wrote: >> Some versions of GCC require insane (>2GB) amounts of memory >> to compile translate.o. As a countermeasure, compile it >> with -O1. This should fix the buildbot failure for >> default_x86_64_fedora16. >

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Peter Maydell
On 27 November 2012 08:34, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory > to compile translate.o. As a countermeasure, compile it > with -O1. This should fix the buildbot failure for > default_x86_64_fedora16. This is a well known bug in old gcc (ie fixed

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Gerd Hoffmann
Hi, > Note that there is probably one or two GCC options that can be > fine-tuned to avoid the explosion instead of just -O1 vs. -O2. If you > have an affected machine (F18) you can help by compiling translate.c > with -O2 -ftime-report. I planned to do this today, but I first need to > instal

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Il 27/11/2012 10:27, Wenchao Xia ha scritto: > In tcg case I think translate.o will influent performance obviously, > how about adding an option "fast-build" to use -O1 for it by default. > If you agree I will adding that after this patch upstream which fix > build bot failure quickly. This is n

Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Wenchao Xia
> Some versions of GCC require insane (>2GB) amounts of memory > to compile translate.o. As a countermeasure, compile it > with -O1. This should fix the buildbot failure for > default_x86_64_fedora16. > > Signed-off-by: Paolo Bonzini > --- > Makefile.target | 2 ++ > 1 file changed, 2 insert

[Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (>2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization

2012-11-27 Thread Paolo Bonzini
Some versions of GCC require insane (>2GB) amounts of memory to compile translate.o. As a countermeasure, compile it with -O1. This should fix the buildbot failure for default_x86_64_fedora16. Signed-off-by: Paolo Bonzini --- Makefile.target | 2 ++ 1 file changed, 2 insertions(+) diff --git