Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-17 Thread Avi Kivity
On 10/17/2012 03:09 AM, Richard Henderson wrote: > On 2012-10-17 09:25, Aurelien Jarno wrote: >>> > +gen_opc_buf[op_index] = op = INDEX_op_mul_i32; >> Very minor nitpick: you probably don't need to set op there. >> > > Perhaps not, but I prefer to keep the variables in sync as we

Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-16 Thread Richard Henderson
On 2012-10-17 09:25, Aurelien Jarno wrote: >> > +gen_opc_buf[op_index] = op = INDEX_op_mul_i32; > Very minor nitpick: you probably don't need to set op there. > Perhaps not, but I prefer to keep the variables in sync as we drop into common code... r~

Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 02, 2012 at 11:32:30AM -0700, Richard Henderson wrote: > Like add2, do operand ordering, constant folding, and dead operand > elimination. The latter happens about 15% of all mulu2 during an > x86_64 bios boot. > > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 26 +++

[Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-02 Thread Richard Henderson
Like add2, do operand ordering, constant folding, and dead operand elimination. The latter happens about 15% of all mulu2 during an x86_64 bios boot. Signed-off-by: Richard Henderson --- tcg/optimize.c | 26 ++ tcg/tcg-op.h | 2 ++ tcg/tcg.c | 19