Re: [Qemu-devel] [PATCH 10/12] VMDK: change get_cluster_offset return type to success flag

2011-06-18 Thread Stefan Hajnoczi
On Sat, Jun 4, 2011 at 1:43 AM, Fam Zheng famc...@gmail.com wrote: +    if (extent-flat) { +               if (m_data) { +                       m_data-valid = 0; +               } Why copy-paste this... +        *cluster_offset = 0; +        return 0; +    }     if (m_data)        

[Qemu-devel] [PATCH 10/12] VMDK: change get_cluster_offset return type to success flag

2011-06-03 Thread Fam Zheng
As mono flat format being introduced, cluster offset of 0 becomes a valid value. get_cluster_offset now return non-zero on fail, and 0 on success. Signed-off-by: Fam Zheng famc...@gmail.com --- block/vmdk.c | 86 - 1 files changed, 54