Re: [Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child

2017-10-11 Thread Max Reitz
On 2017-10-10 11:47, Kevin Wolf wrote: > Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: >> Regarding the source BDS, the mirror BDS is arguably a filter node. >> Therefore, the source BDS should be its "file" child. >> >> Signed-off-by: Max Reitz > > TODO: Justification why this doesn't break

Re: [Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child

2017-10-10 Thread Kevin Wolf
Am 13.09.2017 um 20:19 hat Max Reitz geschrieben: > Regarding the source BDS, the mirror BDS is arguably a filter node. > Therefore, the source BDS should be its "file" child. > > Signed-off-by: Max Reitz TODO: Justification why this doesn't break things like bdrv_is_allocated_above() that itera

[Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child

2017-09-13 Thread Max Reitz
Regarding the source BDS, the mirror BDS is arguably a filter node. Therefore, the source BDS should be its "file" child. Signed-off-by: Max Reitz --- block/mirror.c | 127 ++--- block/qapi.c | 25 ++--- tests/qemu-iotests/14