Re: [Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip

2017-05-30 Thread Eric Blake
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote: > - do not goto into switch block from outer block This sentence didn't quite make sense. Better might be: - do not use 'goto error_reply' outside a switch to jump into the middle of the switch's default case label > - reduce code dupl

[Qemu-devel] [PATCH 10/19] nbd/server: refactor nbd_trip

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
- do not goto into switch block from outer block - reduce code duplications Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 53 - 1 file changed, 20 insertions(+), 33 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index a