Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

2011-10-17 Thread Kevin Wolf
Am 13.10.2011 13:03, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 50 ++ 1 files changed, 42 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 837747f..1786c37

Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

2011-10-17 Thread Paolo Bonzini
On 10/17/2011 05:20 PM, Kevin Wolf wrote: +current = media_is_dvd(s) ? MMC_PROFILE_DVD_ROM : MMC_PROFILE_CD_ROM; +memset(outbuf, 0, 40); Is the memset required at all? I seem to remember that the output buffer was zeroed in generic code. No, it isn't. +stl_be_p(outbuf[0],

[Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

2011-10-13 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 50 ++ 1 files changed, 42 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 837747f..1786c37 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@