On Thu, May 31, 2018 at 7:06 PM, Keno Fischer wrote:
> On Thu, May 31, 2018 at 6:56 PM, Keno Fischer wrote:
My concern was that allowing this would cause unexpected
behavior, since the device numbers will differ between OS X
and Linux. Though maybe this isn't the place to worry abo
On Thu, May 31, 2018 at 6:56 PM, Keno Fischer wrote:
>>> My concern was that allowing this would cause unexpected
>>> behavior, since the device numbers will differ between OS X
>>> and Linux. Though maybe this isn't the place to worry about
>>> that.
>>
>> The numbers may differ indeed but we don
>> My concern was that allowing this would cause unexpected
>> behavior, since the device numbers will differ between OS X
>> and Linux. Though maybe this isn't the place to worry about
>> that.
>
> The numbers may differ indeed but we don't really care since the
> server never opens device files.
On Thu, 31 May 2018 12:37:56 -0400
Keno Fischer wrote:
> >> +#ifdef CONFIG_DARWIN
> >> +/* Darwin doesn't have mknodat and it's unlikely to work anyway,
> >
> > What's unlikely to work ?
> >
>
> My concern was that allowing this would cause unexpected
> behavior, since the device numbers
>> +#ifdef CONFIG_DARWIN
>> +/* Darwin doesn't have mknodat and it's unlikely to work anyway,
>
> What's unlikely to work ?
>
My concern was that allowing this would cause unexpected
behavior, since the device numbers will differ between OS X
and Linux. Though maybe this isn't the place to wor
On Sat, 26 May 2018 01:23:13 -0400
k...@juliacomputing.com wrote:
> From: Keno Fischer
>
> Signed-off-by: Keno Fischer
> ---
> hw/9pfs/9p-local.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index c55ea25..3e358b7 100644
> --- a/h
From: Keno Fischer
Signed-off-by: Keno Fischer
---
hw/9pfs/9p-local.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index c55ea25..3e358b7 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -669,6 +669,13 @@ static int local_mknod(
