Re: [Qemu-devel] [PATCH 11/15] scsi: add xfer mode

2009-11-17 Thread Paul Brook
> add xfer mode This should also be used by scsi-disc.c Paul

Re: [Qemu-devel] [PATCH 11/15] scsi: add xfer mode

2009-11-17 Thread Christoph Hellwig
On Tue, Nov 17, 2009 at 11:17:47AM +0100, Gerd Hoffmann wrote: > +static void scsi_req_xfer_mode(SCSIRequest *req) > +{ > +switch (req->cmd.buf[0]) { Having this as a void seem a bit odd to me. I'd make it return the mode, and maybe just pass the cmd to it to make it more clear. > +static in

[Qemu-devel] [PATCH 11/15] scsi: add xfer mode

2009-11-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/scsi-bus.c | 46 ++ hw/scsi-generic.c | 40 ++-- hw/scsi.h |7 +++ 3 files changed, 59 insertions(+), 34 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-