Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Igor Mammedov
On Mon, 15 Apr 2013 17:49:20 -0300 Eduardo Habkost wrote: > On Mon, Apr 15, 2013 at 10:27:57PM +0200, Igor Mammedov wrote: > > On Mon, 15 Apr 2013 11:49:40 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 15, 2013 at 04:34:41PM +0200, Igor Mammedov wrote: > > > > On Mon, 15 Apr 2013 10:45

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Eduardo Habkost
On Mon, Apr 15, 2013 at 10:27:57PM +0200, Igor Mammedov wrote: > On Mon, 15 Apr 2013 11:49:40 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 15, 2013 at 04:34:41PM +0200, Igor Mammedov wrote: > > > On Mon, 15 Apr 2013 10:45:24 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Mon, Apr 15, 2

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Igor Mammedov
On Mon, 15 Apr 2013 11:49:40 -0300 Eduardo Habkost wrote: > On Mon, Apr 15, 2013 at 04:34:41PM +0200, Igor Mammedov wrote: > > On Mon, 15 Apr 2013 10:45:24 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 15, 2013 at 03:37:00PM +0200, Igor Mammedov wrote: > > > [...] > > > > > > > ID to b

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Eduardo Habkost
On Mon, Apr 15, 2013 at 04:34:41PM +0200, Igor Mammedov wrote: > On Mon, 15 Apr 2013 10:45:24 -0300 > Eduardo Habkost wrote: > > > On Mon, Apr 15, 2013 at 03:37:00PM +0200, Igor Mammedov wrote: > > [...] > > > > > > ID to be directly specified in the device_add/-device options. > > > > > > That's

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Igor Mammedov
On Mon, 15 Apr 2013 10:45:24 -0300 Eduardo Habkost wrote: > On Mon, Apr 15, 2013 at 03:37:00PM +0200, Igor Mammedov wrote: > [...] > > > > > ID to be directly specified in the device_add/-device options. > > > > > That's how real CPUs work: as the CPU manufacturer doesn't know > > > > > what will

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Eduardo Habkost
On Mon, Apr 15, 2013 at 03:37:00PM +0200, Igor Mammedov wrote: [...] > > > > ID to be directly specified in the device_add/-device options. That's > > > > how real CPUs work: as the CPU manufacturer doesn't know what will be > > > > the package ID of the CPU, the APIC IDs are not hardcoded in the

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-15 Thread Igor Mammedov
On Fri, 12 Apr 2013 13:29:40 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 05:46:42PM +0200, Igor Mammedov wrote: > > On Fri, 12 Apr 2013 10:13:13 -0300 > > Eduardo Habkost wrote: > [...] > > > > > > +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void > > > > > > *opaque, >

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-14 Thread li guang
在 2013-04-12五的 13:29 -0300，Eduardo Habkost写道： > On Fri, Apr 12, 2013 at 05:46:42PM +0200, Igor Mammedov wrote: > > On Fri, 12 Apr 2013 10:13:13 -0300 > > Eduardo Habkost wrote: > [...] > > > > > > +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void > > > > > > *opaque, > > > > > > +

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 05:46:42PM +0200, Igor Mammedov wrote: > On Fri, 12 Apr 2013 10:13:13 -0300 > Eduardo Habkost wrote: [...] > > > > > +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void > > > > > *opaque, > > > > > + const char *name, Error **e

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2013 10:13:13 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 12:20:45PM +0200, Igor Mammedov wrote: > > On Thu, 11 Apr 2013 16:12:33 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > > > ... and use it from board

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:20:45PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 16:12:33 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > > ... and use it from board level to set APIC ID for CPUs > > > it creates. > > > > > > Signed-off

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Igor Mammedov
On Thu, 11 Apr 2013 16:12:33 -0300 Eduardo Habkost wrote: > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > ... and use it from board level to set APIC ID for CPUs > > it creates. > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: Paolo Bonzini > > --- > > Note: > > * p

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > ... and use it from board level to set APIC ID for CPUs > it creates. > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini > --- > Note: > * pc_new_cpu() function will be reused later in CPU hot-plug hook. > > v3: > *

[Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-11 Thread Igor Mammedov
... and use it from board level to set APIC ID for CPUs it creates. Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini --- Note: * pc_new_cpu() function will be reused later in CPU hot-plug hook. v3: * user error_propagate() in property setter v2: * use generic cpu_exists() instead o