Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori aligu...@us.ibm.com wrote: diff --git a/qmp-core.h b/qmp-core.h index e3235ec..5ce02f7 100644 --- a/qmp-core.h +++ b/qmp-core.h @@ -21,10 +21,65 @@ typedef struct QmpState QmpState;  typedef void (QmpCommandFunc)(const QDict *, QObject **,

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:21 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguorialigu...@us.ibm.com wrote: diff --git a/qmp-core.h b/qmp-core.h index e3235ec..5ce02f7 100644 --- a/qmp-core.h +++ b/qmp-core.h @@ -21,10 +21,65 @@ typedef struct QmpState QmpState; typedef void

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:53 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/07/2011 07:21 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguorialigu...@us.ibm.com  wrote: diff --git a/qmp-core.h b/qmp-core.h index e3235ec..5ce02f7 100644 --- a/qmp-core.h +++

Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-07 Thread Anthony Liguori
On 03/07/2011 08:36 AM, Stefan Hajnoczi wrote: Technically void (*)() is an obsolete type in standard C. I can switch to void (*)(void) but it requires casting and requires a typeof() :-/ You're right, void (*)(void) is the proper form for a general function pointer. I think doing

[Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

2011-03-06 Thread Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com diff --git a/qmp-core.c b/qmp-core.c index 78aef3a..3a6242c 100644 --- a/qmp-core.c +++ b/qmp-core.c @@ -28,6 +28,22 @@ typedef struct QmpCommand QTAILQ_ENTRY(QmpCommand) node; } QmpCommand; +typedef struct DefaultQmpConnection +{ +