Am 13.10.2011 13:03, schrieb Paolo Bonzini:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/scsi-disk.c | 101
+++-
1 files changed, 100 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index
On 10/21/2011 01:42 PM, Kevin Wolf wrote:
+if (s-qdev.type != TYPE_ROM || !bdrv_is_inserted(s-bs)) {
+return -1;
+}
+if (s-tray_open || !bdrv_is_inserted(s-bs)) {
+scsi_check_condition(r, SENSE_CODE(NO_MEDIUM));
+return -1;
+}
You are
On 10/21/2011 01:42 PM, Kevin Wolf wrote:
There is only one 'goto fail', all other places have a direct return -1.
It would be good to be consistent.
Also, as this is mostly a refactored copy from the ATAPI code, I wonder
what our long-term plan is. At which point will we be able to unify what
Am 21.10.2011 15:12, schrieb Paolo Bonzini:
On 10/21/2011 01:42 PM, Kevin Wolf wrote:
There is only one 'goto fail', all other places have a direct return -1.
It would be good to be consistent.
Also, as this is mostly a refactored copy from the ATAPI code, I wonder
what our long-term plan
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/scsi-disk.c | 101 +++-
1 files changed, 100 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 1786c37..14db6a0 100644
--- a/hw/scsi-disk.c
+++
