Re: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:46PM +0200, Markus Armbruster wrote: Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for PACKET feature set devices. Odd but true, even if it's 7.38.2 in my local copy of the ACS spec. It defintively should be documented in a comment next to the

Re: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM

2011-07-26 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Wed, Jul 20, 2011 at 06:23:46PM +0200, Markus Armbruster wrote: Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for PACKET feature set devices. Odd but true, even if it's 7.38.2 in my local copy of the ACS spec. It defintively should

[Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM

2011-07-20 Thread Markus Armbruster
Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for PACKET feature set devices. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index fa50692..f96ebf2