Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-16 Thread David Gibson
On Thu, Dec 13, 2012 at 02:18:15PM +, Peter Maydell wrote: > On 13 December 2012 14:17, Peter Maydell wrote: > > On 13 December 2012 13:19, Alexander Graf wrote: > >> So because we don't call kvm_arch_init, the cap is 0 and thus we return 1? > > > > No, if we aren't CONFIG_KVM then that sourc

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Peter Maydell
On 13 December 2012 14:17, Peter Maydell wrote: > On 13 December 2012 13:19, Alexander Graf wrote: >> So because we don't call kvm_arch_init, the cap is 0 and thus we return 1? > > No, if we aren't CONFIG_KVM then that source file and version of > the function aren't compiled at all. ...and 5 se

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Peter Maydell
On 13 December 2012 13:19, Alexander Graf wrote: > > On 13.12.2012, at 14:17, David Gibson wrote: > >> On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: >>> What if I am using TCG on PPC? >> >> Then the stub version of kvmppc_smt_threads() returns 1, and since the >> PPC TCG doesn't

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Alexander Graf
On 13.12.2012, at 14:17, David Gibson wrote: > On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: >> >> On 04.12.2012, at 04:11, David Gibson wrote: >> >>> On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: From: Mike Qiu >>> >>> Oops, messed this one up, build er

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread David Gibson
On Thu, Dec 13, 2012 at 01:57:16PM +0100, Alexander Graf wrote: > > On 04.12.2012, at 04:11, David Gibson wrote: > > > On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: > >> From: Mike Qiu > > > > Oops, messed this one up, build error for user only builds. Fixed > > version below.

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-13 Thread Alexander Graf
On 04.12.2012, at 04:11, David Gibson wrote: > On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: >> From: Mike Qiu > > Oops, messed this one up, build error for user only builds. Fixed > version below. > > From d2cc6bcee4737647c4bbbf65d3c0129d4a119dd3 Mon Sep 17 00:00:00 2001 > Fr

[Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-03 Thread David Gibson
From: Mike Qiu Currently the target-ppc tcg code only supports a single thread. You can specify more, but they're treated identically to multiple cores. On KVM we obviously can't support more threads than the hardware; if more are specified it will cause strange and cryptic errors. This patch

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-03 Thread David Gibson
On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: > From: Mike Qiu Oops, messed this one up, build error for user only builds. Fixed version below. >From d2cc6bcee4737647c4bbbf65d3c0129d4a119dd3 Mon Sep 17 00:00:00 2001 From: Mike Qiu Date: Tue, 4 Dec 2012 10:52:14 +1100 Subject: [