Re: [Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list.

2011-08-17 Thread Avi Kivity
On 08/16/2011 09:45 AM, Richard Henderson wrote: @@ -1873,20 +1874,30 @@ void ide_init2_with_non_qdev_drives(IDEBus *bus, DriveInfo *hd0, bus-dma =ide_dma_nop; } -void ide_init_ioport(IDEBus *bus, int iobase, int iobase2) +static const MemoryRegionPortio ide_portio_list[] = { +{0,

Re: [Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list.

2011-08-17 Thread Richard Henderson
On 08/17/2011 07:04 AM, Avi Kivity wrote: Which PCI-ISA bridge? The only implied by isa_bus_new. If you're behind a secondary PCI bridge, you've now bypassed its filtering. ... Which we never will be, since the PCI-ISA bridge is not explicitly emulated, but only implied via the way we mash

Re: [Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list.

2011-08-17 Thread Avi Kivity
On 08/17/2011 07:04 AM, Avi Kivity wrote: + +void ide_init_ioport(IDEBus *bus, ISADevice *dev, int iobase, int iobase2) { -register_ioport_write(iobase, 8, 1, ide_ioport_write, bus); -register_ioport_read(iobase, 8, 1, ide_ioport_read, bus); +/* ??? Assume only ISA and PCI

[Qemu-devel] [PATCH 13/14] ide: Convert to isa_register_old_portio_list.

2011-08-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- hw/ide/core.c | 33 ++--- hw/ide/internal.h |3 ++- hw/ide/isa.c |4 +--- hw/ide/piix.c |7 --- hw/ide/via.c |7 --- 5 files changed, 33 insertions(+), 21 deletions(-)