Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-23 Thread Paolo Bonzini
Il 23/08/2013 11:00, Lei Li ha scritto: >>> The performance assurance is very important to this feature, our goal is >>> 100ms of downtime for a 1TB guest. >> >> I honestly doubt that 100ms of downtime is possible while the machine is >> stopped. A 1TB guest has 2^28 = 268*10^6 pages, which you wa

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-23 Thread Lei Li
On 08/23/2013 03:48 PM, Paolo Bonzini wrote: Il 23/08/2013 08:25, Lei Li ha scritto: On 08/21/2013 06:48 PM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. You should im

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-23 Thread Paolo Bonzini
Il 23/08/2013 09:57, Alex Bligh ha scritto: > > > --On 23 August 2013 09:48:42 +0200 Paolo Bonzini > wrote: > >> As a matter of fact, 2^28 madvise system calls will take much, much >> longer than 100ms. > > Probably a stupid question, but why would you need to do one call per > page? It takes

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-23 Thread Alex Bligh
--On 23 August 2013 09:48:42 +0200 Paolo Bonzini wrote: As a matter of fact, 2^28 madvise system calls will take much, much longer than 100ms. Probably a stupid question, but why would you need to do one call per page? It takes a 'size_t length' parameter. -- Alex Bligh

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-23 Thread Paolo Bonzini
Il 23/08/2013 08:25, Lei Li ha scritto: > On 08/21/2013 06:48 PM, Paolo Bonzini wrote: >> Il 21/08/2013 09:18, Lei Li ha scritto: >>> Send all the ram blocks hooked by save_page, which will copy >>> ram page and MADV_DONTNEED the page just copied. >> You should implement this entirely in the hook.

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-22 Thread Lei Li
On 08/21/2013 06:48 PM, Paolo Bonzini wrote: Il 21/08/2013 09:18, Lei Li ha scritto: Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. You should implement this entirely in the hook. It will be a little less efficient because of the d

Re: [Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 09:18, Lei Li ha scritto: > Send all the ram blocks hooked by save_page, which will copy > ram page and MADV_DONTNEED the page just copied. You should implement this entirely in the hook. It will be a little less efficient because of the dirty bitmap overhead, but you should aim at

[Qemu-devel] [PATCH 13/18] arch_init: adjust ram_save_setup() for migrate_is_localhost

2013-08-21 Thread Lei Li
Send all the ram blocks hooked by save_page, which will copy ram page and MADV_DONTNEED the page just copied. Signed-off-by: Lei Li --- arch_init.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 434a4ca..cbbb4db 100644