Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-02-03 Thread Paolo Bonzini
On 02/02/2015 22:09, John Snow wrote: In this case, only the command header had a utility written for it to flip the bits for me. This is part of the FIS, instead, which has no explicit flip-on-write mechanism inside of commit. So, it's correct, but not terribly consistent. I can

Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-02-02 Thread John Snow
On 02/02/2015 05:35 AM, Paolo Bonzini wrote: On 30/01/2015 19:42, John Snow wrote: +void ahci_command_set_sizes(AHCICommand *cmd, uint64_t xbytes, +unsigned prd_size) +{ +/* Each PRD can describe up to 4MiB, and must not be odd. */ +

Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-02-02 Thread Paolo Bonzini
On 30/01/2015 19:42, John Snow wrote: +void ahci_command_set_sizes(AHCICommand *cmd, uint64_t xbytes, +unsigned prd_size) +{ +/* Each PRD can describe up to 4MiB, and must not be odd. */ +g_assert_cmphex(prd_size, =, 4096 * 1024); +

[Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-01-30 Thread John Snow
Adds setters for size, prd_size and both via set_sizes. Signed-off-by: John Snow js...@redhat.com --- tests/libqos/ahci.c | 22 ++ tests/libqos/ahci.h | 5 + 2 files changed, 27 insertions(+) diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c index 594c821..3375d54